Skip to content

🐛 [Frontend] Fix: Share workspaces #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

🐛 [Frontend] Fix: Share workspaces #8242

merged 1 commit into from
Aug 21, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 21, 2025 •
edited
Loading

What do these changes do?

reported by @JavierGOrdonnez

Sharing workspaces was broken. Fixed:
ShareWorkspace

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Voyager milestone Aug 21, 2025
@odeimaiz odeimaiz self-assigned this Aug 21, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz requested a review from Copilot August 21, 2025 12:32
Copilot AI reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes workspace sharing functionality by adding accessRights properties to role definitions. The change standardizes role permissions by explicitly defining read, write, and delete access rights for each role level.

  • Adds explicit access rights configuration to role definitions
  • Ensures consistent permission mapping across viewer, write, and delete roles

@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) 🤖-automerge marks PR as ready to be merged for Mergify labels Aug 21, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Aug 21, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2025 •
edited
Loading

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 033c534.

🟢 All jobs passed!

But CI Insights is watching 👀

@odeimaiz odeimaiz merged commit 81315d3 into ITISFoundation:master Aug 21, 2025
58 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@JavierGOrdonnez JavierGOrdonnez Awaiting requested review from JavierGOrdonnez

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

Shared Workspaces multiple issues

3 participants

@odeimaiz @giancarloromeo @GitHK